Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(headless): deprecate tabs shorthand api #995

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented Oct 12, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests
  • Other

Why is it needed?

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have add necessary docs (if needed)
  • Added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented Oct 12, 2024

🦋 Changeset detected

Latest commit: 121aa73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@qwik-ui/headless Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 12, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/qwikifiers/qwik-ui@995
pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/headless@995
pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/styled@995
pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/utils@995

commit: 121aa73

@maiieul maiieul changed the title chore: deprecate tabs shorthand api chore(headless): deprecate tabs shorthand api Oct 12, 2024
@maiieul maiieul marked this pull request as draft October 12, 2024 19:29
@maiieul
Copy link
Contributor Author

maiieul commented Oct 12, 2024

I want to do a release before merging this

// The consumer must provide a key if they change the order
const matchedTabComponent = tabComponents[panelIndex];
const tabIdFromTabMaybe =
(matchedTabComponent?.props as TabProps).tabId || matchedTabComponent?.key;
const tabId: string = tabIdFromTabMaybe || child.key || `${panelIndex}`;

if (label) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comments instead of removing for deprecation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant